jerrypeng commented on a change in pull request #1885: allow users to specify
message timeout for functions
URL: https://github.com/apache/incubator-pulsar/pull/1885#discussion_r192471378
##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -69,6 +69,7 @@ message SourceSpec {
// configs used only when source feeds into functions
SubscriptionType subscriptionType = 3;
map<string,string> topicsToSerDeClassName = 4;
+ uint64 timeoutMs = 6;
Review comment:
Everything field under the comment:
"// configs used only when source feeds into functions"
are pulsar source specific configs. We didn't name them pulsar source
specific thus, I don't think we should that it for timeoutMs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
