jerrypeng commented on a change in pull request #1885: allow users to specify
message timeout for functions
URL: https://github.com/apache/incubator-pulsar/pull/1885#discussion_r192474989
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSourceConfig.java
##########
@@ -37,6 +37,7 @@
private String subscriptionName;
private Map<String, String> topicSerdeClassNameMap;
private String typeClassName;
+ private Long timeoutMs;
Review comment:
I think this is ok. I am not sure there is a use case for different
timeouts for different topics. How long a message is buffered is usually
independent of which topic its from. If a user really wants that to do
something like that, they can always create separate functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
