jerrypeng commented on a change in pull request #1902: Support function 
registration with package-url
URL: https://github.com/apache/incubator-pulsar/pull/1902#discussion_r192842809
 
 

 ##########
 File path: 
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java
 ##########
 @@ -121,6 +121,23 @@ public void createFunction(FunctionDetails 
functionDetails, String fileName) thr
         }
     }
 
+    @Override
+    public void createFunctionWithUrl(FunctionDetails functionDetails, String 
pkgUrl) throws PulsarAdminException {
 
 Review comment:
   Is this used somewhere? Don't we need to modify the CmdFunctions to use this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to