jerrypeng commented on a change in pull request #1902: Support function 
registration with package-url
URL: https://github.com/apache/incubator-pulsar/pull/1902#discussion_r192857686
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -85,6 +85,7 @@ message SinkSpec {
 
 message PackageLocationMetaData {
     string packagePath = 1;
+    string packageUrl = 2;
 
 Review comment:
   should we have another field here? or can we just use the existing field 
'packagePath' and switch logic on the prefix e.g. http

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to