jerrypeng commented on a change in pull request #1845: Functions schema
integration
URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r193899502
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java
##########
@@ -49,14 +54,11 @@ public JavaInstance(InstanceConfig config, Object
userClassObject,
PulsarClient pulsarClient,
Source source) {
// TODO: cache logger instances by functions?
- Logger instanceLog = LoggerFactory.getLogger("function-" +
config.getFunctionDetails().getName());
-
- if (source instanceof PulsarSource) {
Review comment:
We should try to create a new ContextImpl object in handle message since
that is called on every message. This may incur high GC costs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
