jerrypeng commented on a change in pull request #1845: Functions schema
integration
URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r193901095
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
##########
@@ -36,20 +53,16 @@
import org.apache.pulsar.io.core.Source;
import org.jboss.util.Classes;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.concurrent.TimeUnit;
-
@Slf4j
-public class PulsarSource<T> implements Source<T> {
Review comment:
since we are pretty much make the Pulsar source into a push source here, can
we just use the following push source abstract class:
https://github.com/apache/incubator-pulsar/blob/master/pulsar-io/core/src/main/java/org/apache/pulsar/io/core/PushSource.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
