sijie opened a new pull request #1994: Issue 1967: Non-persistent topic drop too many messages URL: https://github.com/apache/incubator-pulsar/pull/1994 *Motivation* Fixes #1967. in 2.0 there is an optimization change on grouping acknowledgements. The [optimization change](https://github.com/apache/incubator-pulsar/commit/19dd2c502725e3b45e56541576508626c4213091#diff-debb36270f152d2533b03902f214fa9aR674) avoided delivering messages that are already "delivered". However in non-persistent topic, pulsar doesn't store entries to bookkeeper, so no ledger id and entry id are assigned for those messages. Pulsar uses 0 for both ledger id and entry. So the optimization change treats messages as already "delivered". so pulsar client doesn't dispatch those messages even it already received them from broker. *Changes* - Make AcknowledgementsGroupingTracker an interface - Introduce a no-op implementation for non-persistent topics Signed-off-by: Sijie Guo <[email protected]>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
