jerrypeng commented on issue #1988: Fix: avoid closing RuntimeFactory when any function stops URL: https://github.com/apache/incubator-pulsar/pull/1988#issuecomment-398526046 @rdhabalia I am not sure this is correct. RuntimeFactory is used on a per function instance basis. RuntimeFactory is not used across different functions. A typical work flow for when you are submitting a function to a worker is the function actioner will create a runtime spawner for a function instance (usually to spawn a process) and the Java instance main will also create a runtime spawner to spawn a thread. When the runtime spawner closes, we need the runtime factory to close to especially if the runtime factory is the thread runtime factory (process runtime factory close is a no op) because it needs to close the pulsar client initialized in the thread runtime factory. #1833 only closes JavaInstanceMain (main function for function instance process) when it detects that the worker is dead. When that happens, it will commit suicide. The RuntimeFactory that JavaInstanceMain closes will always be the threadRuntimeFactory
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
