sijie commented on a change in pull request #2101: Migrate compaction and s3
offload test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202105798
##########
File path:
tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java
##########
@@ -187,7 +203,7 @@ public void start() throws Exception {
public void stop() {
- Stream<GenericContainer> list1 = Stream.of(proxyContainer,
csContainer, zkContainer);
+ Stream<GenericContainer> list1 = Stream.of(proxyContainer,
csContainer, zkContainer, s3Container);
Review comment:
if s3Container is not started, why do you need to stop it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
