rdhabalia commented on a change in pull request #2187: Removed the
`Context.ack(byte[] messageId)` and expose `Record` instead
URL: https://github.com/apache/incubator-pulsar/pull/2187#discussion_r203210773
##########
File path: pulsar-io/kinesis/pom.xml
##########
@@ -38,6 +38,13 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-functions-instance</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
> I have moved EncryptionContext out of Record (main reason is that it's
really tied to Pulsar client API and not relevant to other sources and sinks).
But if Pulsar record is encrypted then this context anyway will be required
by any sink. So, I think `EncryptionContext` should be part of `Record`.??
> I have added a new interface RecordWithEncryptionContext in
pulsar-functions-instance,
yes, it seems we should have light weight pulsar-function-common which keeps
common types for other modules. so, artifact doesn't have to depend on
actual-impl-artifacts such as pulsar-function-instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
