rdhabalia commented on a change in pull request #2187: Removed the
`Context.ack(byte[] messageId)` and expose `Record` instead
URL: https://github.com/apache/incubator-pulsar/pull/2187#discussion_r203264915
##########
File path: pulsar-io/kinesis/pom.xml
##########
@@ -38,6 +38,13 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-functions-instance</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
yes, I saw that change but my only point was that for any
Sink-implementation, source will be always a Pulsar and there could be
possibility that record is encrypted so, `EncryptionCtx` could be a first class
entity so, might be right thing to keep in Record.
But if you strongly believe to create another type as
`RecordWithEncryptionContext` then I will be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
