merlimat commented on a change in pull request #2187: Removed the
`Context.ack(byte[] messageId)` and expose `Record` instead
URL: https://github.com/apache/incubator-pulsar/pull/2187#discussion_r203244621
##########
File path: pulsar-io/kinesis/pom.xml
##########
@@ -38,6 +38,13 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-functions-instance</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
Look at
https://github.com/apache/incubator-pulsar/pull/2187/files#diff-5df4e50a01720cb0f526ef575cc4d66fR71
for how it got changed for the kinesis sink to access the encryption context.
More than lightweight, I think it's preferable to separate the API
dependencies. Also, that interface really only applies to PulsarRecord and not
any other implementations. For the dependency, yes it could be introduced a
functions-common, but depending on pulsar-function-instance doesn't add any
"real" dependency, since that module is by definition always in the class path,
in every execution mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
