merlimat commented on a change in pull request #2187: Removed the
`Context.ack(byte[] messageId)` and expose `Record` instead
URL: https://github.com/apache/incubator-pulsar/pull/2187#discussion_r203492473
##########
File path: pulsar-io/kinesis/pom.xml
##########
@@ -38,6 +38,13 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-functions-instance</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review comment:
Let see how more sink implementations might use that info. It's always easy
to add more context in the interfaces, though it would be harder to remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
