jerrypeng commented on a change in pull request #2259: Fix: set
subscription-type based on message ordering
URL: https://github.com/apache/incubator-pulsar/pull/2259#discussion_r206628659
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -560,24 +565,10 @@ protected FunctionDetails convert(FunctionConfig
functionConfig)
sourceSpecBuilder.setTopicsPattern(functionConfig.getTopicsPattern());
}
- // Set subscription type based on processing semantics
- if (functionConfig.getProcessingGuarantees() != null) {
Review comment:
I don't think we should get rid of this logic. It is a better user
experience if the user just specify a processing guarantee and subscription is
automatically set for them. In general, users will be more familiar with
processing guarantee terminology than subscription terminology. We can have an
option for the to override the subscription type from the CLI if the user wants
to do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
