jerrypeng commented on a change in pull request #2259: Fix: set
subscription-type based on message ordering
URL: https://github.com/apache/incubator-pulsar/pull/2259#discussion_r206634267
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -560,24 +565,10 @@ protected FunctionDetails convert(FunctionConfig
functionConfig)
sourceSpecBuilder.setTopicsPattern(functionConfig.getTopicsPattern());
}
- // Set subscription type based on processing semantics
- if (functionConfig.getProcessingGuarantees() != null) {
Review comment:
If a user specifies a processing guarantee of effectively once, the
subscription by default should be Failover and the user shouldn't also need to
specify retain order because it is implied
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
