ivankelly commented on a change in pull request #2219: Cpp client: add
PatternMultiTopicsConsumerImpl to support regex subscribe
URL: https://github.com/apache/incubator-pulsar/pull/2219#discussion_r205828842
##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -212,6 +217,65 @@ void ClientImpl::handleReaderMetadataLookup(const Result
result, const LookupDat
consumers_.push_back(reader->getConsumer());
}
+void ClientImpl::subscribeAsync(const std::string& regexPattern, const
std::string& consumerName,
+ const ConsumerConfiguration& conf, bool
useRegex,
Review comment:
This assumes that the regex will be somehting like
"my-tenant/my-ns/my-topic-[0-9]*". As in, the namespace has to exist in the
pattern if it's non-default?
We should validate that the tenant and namespace are valid and that the user
hasn't tried to put a regex there also. I guess this will happen automatically
with TopicName::get.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
