ivankelly commented on a change in pull request #2219: Cpp client: add
PatternMultiTopicsConsumerImpl to support regex subscribe
URL: https://github.com/apache/incubator-pulsar/pull/2219#discussion_r205828271
##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -212,6 +217,65 @@ void ClientImpl::handleReaderMetadataLookup(const Result
result, const LookupDat
consumers_.push_back(reader->getConsumer());
}
+void ClientImpl::subscribeAsync(const std::string& regexPattern, const
std::string& consumerName,
+ const ConsumerConfiguration& conf, bool
useRegex,
Review comment:
remove useRegex. If we see more different pattern types happening in future,
then rename to subscribeRegexAsync. I can't see what other pattern you'd use
though. Regex is ubiquitous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
