rdhabalia commented on a change in pull request #2261: Avoid creating output
topic on tenant namespace if output-topic not provided
URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r207696396
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig
functionConfig) {
if (StringUtils.isEmpty(functionConfig.getNamespace())) {
inferMissingNamespace(functionConfig);
}
- if (StringUtils.isEmpty(functionConfig.getOutput())) {
Review comment:
> if people want to disable sink, there should be another flag controlling
that.
I think when user submits function, user doesn't care about source or sink
and as a user one
doesn't want to redirect output to any unknown topic. seems like adding
extra flag makes output topic mandatory. not sure if that's a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
