rdhabalia commented on a change in pull request #2261: Avoid creating output
topic on tenant namespace if output-topic not provided
URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r206275494
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig
functionConfig) {
if (StringUtils.isEmpty(functionConfig.getNamespace())) {
inferMissingNamespace(functionConfig);
}
- if (StringUtils.isEmpty(functionConfig.getOutput())) {
Review comment:
but if user doesn't provide output topic name then it means user is not
intended to publish output in the external topic. I think here, adding a flag
creates a confusion which is not known by the user. So, as a user, I feel it's
better if cli doesn't compute output topic if it's not provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
