merlimat commented on a change in pull request #2351: Avoid double executor on
non-persistent topic send operation
URL: https://github.com/apache/incubator-pulsar/pull/2351#discussion_r209143378
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
##########
@@ -188,44 +188,32 @@ public NonPersistentTopic(String topic, BrokerService
brokerService) {
@Override
public void publishMessage(ByteBuf data, PublishContext callback) {
Review comment:
In this case, since this is non-persistent, we don't need to be in the
ordered executor. We are in the IO thread from the connection of the producer
and that's already enough to guarantee per-producer ordering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
