merlimat commented on a change in pull request #2351: Avoid double executor on
non-persistent topic send operation
URL: https://github.com/apache/incubator-pulsar/pull/2351#discussion_r209143603
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
##########
@@ -188,44 +188,32 @@ public NonPersistentTopic(String topic, BrokerService
brokerService) {
@Override
public void publishMessage(ByteBuf data, PublishContext callback) {
- AtomicInteger msgDeliveryCount = new AtomicInteger(2);
+ callback.completed(null, 0L, 0L);
Review comment:
We can, but it won't change much in any case. The reason is that if the
dispatch is taking more time, the IO thread is anyway blocked and we would not
proceed to process the upcoming messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
