srkukarni closed pull request #2532: When WindowConfig is set, automatically
default autoAck to false
URL: https://github.com/apache/incubator-pulsar/pull/2532
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
index 777ec93736..e8c874059c 100644
---
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
+++
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
@@ -569,11 +569,6 @@ private void inferMissingArguments(FunctionConfig
functionConfig) {
WindowConfig windowConfig = functionConfig.getWindowConfig();
if (windowConfig != null) {
WindowUtils.inferDefaultConfigs(windowConfig);
- // set auto ack to false since windowing framework is
responsible
- // for acking and not the function framework
- if (autoAck) {
- throw new ParameterException("Cannot enable auto ack when
using windowing functionality");
- }
functionConfig.setAutoAck(false);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
