[incubator-pulsar] branch master updated: When WindowConfig is set, automatically default autoAck to false (#2532)

[sanjeevrk]

This is an automated email from the ASF dual-hosted git repository.

sanjeevrk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 59df98b  When WindowConfig is set, automatically default autoAck to 
false (#2532)
59df98b is described below

commit 59df98bd5675fa17cc858fa2a0c5cac45475a5f4
Author: Sanjeev Kulkarni <sanjee...@gmail.com>
AuthorDate: Thu Sep 6 20:54:42 2018 -0700

    When WindowConfig is set, automatically default autoAck to false (#2532)
---
 .../src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java      | 5 -----
 1 file changed, 5 deletions(-)

diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
index 777ec93..e8c8740 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
@@ -569,11 +569,6 @@ public class CmdFunctions extends CmdBase {
             WindowConfig windowConfig = functionConfig.getWindowConfig();
             if (windowConfig != null) {
                 WindowUtils.inferDefaultConfigs(windowConfig);
-                // set auto ack to false since windowing framework is 
responsible
-                // for acking and not the function framework
-                if (autoAck) {
-                    throw new ParameterException("Cannot enable auto ack when 
using windowing functionality");
-                }
                 functionConfig.setAutoAck(false);
             }
         }