Author: robbie
Date: Mon Feb 13 01:07:26 2012
New Revision: 1243389
URL: http://svn.apache.org/viewvc?rev=1243389&view=rev
Log:
QPID-3817: remove unnecessary cast to AMQQueue from the QueueBrowser creation
path to allow their use with Address syntax 'destination.<address>' entries in
JNDI properties files.
Applied patch from Praveen Murugesan
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java?rev=1243389&r1=1243388&r2=1243389&view=diff
==============================================================================
---
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java
(original)
+++
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java
Mon Feb 13 01:07:26 2012
@@ -39,11 +39,11 @@ public class AMQQueueBrowser implements
private AtomicBoolean _isClosed = new AtomicBoolean();
private final AMQSession _session;
- private final AMQQueue _queue;
+ private final Queue _queue;
private final ArrayList<BasicMessageConsumer> _consumers = new
ArrayList<BasicMessageConsumer>();
private final String _messageSelector;
- AMQQueueBrowser(AMQSession session, AMQQueue queue, String
messageSelector) throws JMSException
+ AMQQueueBrowser(AMQSession session, Queue queue, String messageSelector)
throws JMSException
{
_session = session;
_queue = queue;
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java?rev=1243389&r1=1243388&r2=1243389&view=diff
==============================================================================
---
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
(original)
+++
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
Mon Feb 13 01:07:26 2012
@@ -952,6 +952,9 @@ public abstract class AMQSession<C exten
return createBrowser(queue, null);
}
+ /**
+ * Create a queue browser if the destination is a valid queue.
+ */
public QueueBrowser createBrowser(Queue queue, String messageSelector)
throws JMSException
{
if (isStrictAMQP())
@@ -962,7 +965,7 @@ public abstract class AMQSession<C exten
checkNotClosed();
checkValidQueue(queue);
- return new AMQQueueBrowser(this, (AMQQueue) queue, messageSelector);
+ return new AMQQueueBrowser(this, queue, messageSelector);
}
protected MessageConsumer createBrowserConsumer(Destination destination,
String messageSelector, boolean noLocal)
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
