Author: kwall
Date: Mon Feb 13 09:11:46 2012
New Revision: 1243448

URL: http://svn.apache.org/viewvc?rev=1243448&view=rev
Log:
QPID-3825: TransactionTimeoutTests sporadically fail

Increase the tolerance around the number of received alert messages to allow 
for running on slower CI box.

Modified:
    
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/transacted/TransactionTimeoutTestCase.java

Modified: 
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/transacted/TransactionTimeoutTestCase.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/transacted/TransactionTimeoutTestCase.java?rev=1243448&r1=1243447&r2=1243448&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/transacted/TransactionTimeoutTestCase.java
 (original)
+++ 
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/transacted/TransactionTimeoutTestCase.java
 Mon Feb 13 09:11:46 2012
@@ -52,6 +52,7 @@ import java.util.concurrent.atomic.Atomi
  */
 public abstract class TransactionTimeoutTestCase extends QpidBrokerTestCase 
implements ExceptionListener
 {
+    private static final int ALERT_MESSAGE_TOLERANCE = 6;
     public static final String VIRTUALHOST = "test";
     public static final String TEXT = "0123456789abcdefghiforgettherest";
     public static final String CHN_OPEN_TXN = "CHN-1007";
@@ -189,7 +190,7 @@ public abstract class TransactionTimeout
         }
         else
         {
-               assertTrue(idleErr, idleMsgs.size() >= idle - 2 && 
idleMsgs.size() <= idle + 2);
+               assertTrue(idleErr, idleMsgs.size() >= idle - 
ALERT_MESSAGE_TOLERANCE && idleMsgs.size() <= idle + ALERT_MESSAGE_TOLERANCE);
         }
         
         if (open == 0)
@@ -198,7 +199,7 @@ public abstract class TransactionTimeout
         }
         else
         {
-            assertTrue(openErr, openMsgs.size() >= open - 2 && openMsgs.size() 
<= open + 2);
+            assertTrue(openErr, openMsgs.size() >= open - 
ALERT_MESSAGE_TOLERANCE && openMsgs.size() <= open + ALERT_MESSAGE_TOLERANCE);
         }
     }
 



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to