Repository: ranger Updated Branches: refs/heads/master b3dc7bd42 -> f8931ff65
RANGER-1868 : Good coding practice in Ranger recommended by static code analysis Project: http://git-wip-us.apache.org/repos/asf/ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/f8931ff6 Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/f8931ff6 Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/f8931ff6 Branch: refs/heads/master Commit: f8931ff65721a49cfd7998522f75774bb3e861e6 Parents: b3dc7bd Author: Nikhil P <nikhil.pur...@gmail.com> Authored: Wed Nov 1 17:11:37 2017 +0530 Committer: Mehul Parikh <me...@apache.org> Committed: Thu Nov 9 18:57:07 2017 +0530 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/security/SecureClientLogin.java | 3 +++ .../java/org/apache/ranger/services/storm/client/StormClient.java | 1 + 2 files changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ranger/blob/f8931ff6/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java ---------------------------------------------------------------------- diff --git a/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java b/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java index e4d6a39..05d23fd 100644 --- a/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java +++ b/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java @@ -49,6 +49,7 @@ public class SecureClientLogin { SecureClientLoginConfiguration loginConf = new SecureClientLoginConfiguration(true, user, path); LoginContext login = new LoginContext("hadoop-keytab-kerberos", subject, null, loginConf); subject.getPrincipals().add(new User(user, AuthenticationMethod.KERBEROS, login)); + login.logout(); login.login(); return login.getSubject(); } catch (LoginException le) { @@ -63,6 +64,7 @@ public class SecureClientLogin { LoginContext login = new LoginContext("hadoop-keytab-kerberos", subject, null, loginConf); KerberosName.setRules(nameRules); subject.getPrincipals().add(new User(user, AuthenticationMethod.KERBEROS, login)); + login.logout(); login.login(); return login.getSubject(); } catch (LoginException le) { @@ -76,6 +78,7 @@ public class SecureClientLogin { SecureClientLoginConfiguration loginConf = new SecureClientLoginConfiguration(false, user, password); LoginContext login = new LoginContext("hadoop-keytab-kerberos", subject, null, loginConf); subject.getPrincipals().add(new User(user, AuthenticationMethod.KERBEROS, login)); + login.logout(); login.login(); return login.getSubject(); } catch (LoginException le) { http://git-wip-us.apache.org/repos/asf/ranger/blob/f8931ff6/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java ---------------------------------------------------------------------- diff --git a/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java b/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java index 46e370e..363a656 100644 --- a/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java +++ b/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java @@ -251,6 +251,7 @@ public class StormClient { null, loginConf); LOG.debug("executeUnderKerberos():Logging in.."); + loginContext.logout(); loginContext.login(); LOG.info("Init Login: using username/password"); loginSubj = loginContext.getSubject();
