Repository: ranger Updated Branches: refs/heads/ranger-0.7 e5a272cf8 -> 8320f0847
RANGER-1868 : Good coding practice in Ranger recommended by static code analysis Signed-off-by: Mehul Parikh <me...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/8320f084 Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/8320f084 Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/8320f084 Branch: refs/heads/ranger-0.7 Commit: 8320f0847725cd2ed4a23f0b2c99f23d129d0192 Parents: e5a272c Author: Nikhil P <nikhil.pur...@gmail.com> Authored: Fri Nov 10 12:32:38 2017 +0530 Committer: Mehul Parikh <me...@apache.org> Committed: Fri Nov 10 13:40:23 2017 +0530 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/security/SecureClientLogin.java | 3 +++ .../java/org/apache/ranger/services/storm/client/StormClient.java | 1 + 2 files changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ranger/blob/8320f084/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java ---------------------------------------------------------------------- diff --git a/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java b/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java index 140d87e..0f0da96 100644 --- a/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java +++ b/agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java @@ -49,6 +49,7 @@ public class SecureClientLogin { SecureClientLoginConfiguration loginConf = new SecureClientLoginConfiguration(true, user, path); LoginContext login = new LoginContext("hadoop-keytab-kerberos", subject, null, loginConf); subject.getPrincipals().add(new User(user, AuthenticationMethod.KERBEROS, login)); + login.logout(); login.login(); return login.getSubject(); } catch (LoginException le) { @@ -63,6 +64,7 @@ public class SecureClientLogin { LoginContext login = new LoginContext("hadoop-keytab-kerberos", subject, null, loginConf); KerberosName.setRules(nameRules); subject.getPrincipals().add(new User(user, AuthenticationMethod.KERBEROS, login)); + login.logout(); login.login(); return login.getSubject(); } catch (LoginException le) { @@ -76,6 +78,7 @@ public class SecureClientLogin { SecureClientLoginConfiguration loginConf = new SecureClientLoginConfiguration(false, user, password); LoginContext login = new LoginContext("hadoop-keytab-kerberos", subject, null, loginConf); subject.getPrincipals().add(new User(user, AuthenticationMethod.KERBEROS, login)); + login.logout(); login.login(); return login.getSubject(); } catch (LoginException le) { http://git-wip-us.apache.org/repos/asf/ranger/blob/8320f084/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java ---------------------------------------------------------------------- diff --git a/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java b/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java index b72a9a2..cd622f4 100644 --- a/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java +++ b/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java @@ -308,6 +308,7 @@ public class StormClient { null, loginConf); LOG.debug("executeUnderKerberos():Logging in.."); + loginContext.logout(); loginContext.login(); LOG.info("Init Login: using username/password"); loginSubj = loginContext.getSubject();
