Repository: reef Updated Branches: refs/heads/master 7f00d994e -> db3530528
[REEF-1046] Fix typos in TestConfigurationBuilder and fill all TODO package-info in Tang JIRA: [REEF-1046](https://issues.apache.org/jira/browse/REEF-1046) Pull Request: This closes #711 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/db353052 Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/db353052 Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/db353052 Branch: refs/heads/master Commit: db35305284acdb84c6f2e395d8414de91cfb060a Parents: 7f00d99 Author: Dongjoon Hyun <[email protected]> Authored: Mon Dec 7 22:18:44 2015 +0900 Committer: Andrew Chung <[email protected]> Committed: Mon Dec 7 10:08:08 2015 -0800 ---------------------------------------------------------------------- .../java/org/apache/reef/tang/examples/package-info.java | 2 +- .../java/org/apache/reef/tang/examples/package-info.java | 2 +- .../java/org/apache/reef/tang/examples/package-info.java | 2 +- .../java/org/apache/reef/tang/formats/package-info.java | 2 +- .../reef/tang/implementation/avro/package-info.java | 2 +- .../implementation/java/TestConfigurationBuilder.java | 10 +++++----- .../reef/tang/implementation/java/package-info.java | 2 +- .../org/apache/reef/tang/implementation/package-info.java | 2 +- .../src/test/java/org/apache/reef/tang/package-info.java | 2 +- 9 files changed, 13 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang-test-jarA/src/main/java/org/apache/reef/tang/examples/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang-test-jarA/src/main/java/org/apache/reef/tang/examples/package-info.java b/lang/java/reef-tang/tang-test-jarA/src/main/java/org/apache/reef/tang/examples/package-info.java index a38f3d3..b0faf10 100644 --- a/lang/java/reef-tang/tang-test-jarA/src/main/java/org/apache/reef/tang/examples/package-info.java +++ b/lang/java/reef-tang/tang-test-jarA/src/main/java/org/apache/reef/tang/examples/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tang test example package. */ package org.apache.reef.tang.examples; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang-test-jarAB/src/main/java/org/apache/reef/tang/examples/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang-test-jarAB/src/main/java/org/apache/reef/tang/examples/package-info.java b/lang/java/reef-tang/tang-test-jarAB/src/main/java/org/apache/reef/tang/examples/package-info.java index a38f3d3..b0faf10 100644 --- a/lang/java/reef-tang/tang-test-jarAB/src/main/java/org/apache/reef/tang/examples/package-info.java +++ b/lang/java/reef-tang/tang-test-jarAB/src/main/java/org/apache/reef/tang/examples/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tang test example package. */ package org.apache.reef.tang.examples; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang-test-jarB/src/main/java/org/apache/reef/tang/examples/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang-test-jarB/src/main/java/org/apache/reef/tang/examples/package-info.java b/lang/java/reef-tang/tang-test-jarB/src/main/java/org/apache/reef/tang/examples/package-info.java index a38f3d3..b0faf10 100644 --- a/lang/java/reef-tang/tang-test-jarB/src/main/java/org/apache/reef/tang/examples/package-info.java +++ b/lang/java/reef-tang/tang-test-jarB/src/main/java/org/apache/reef/tang/examples/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tang test example package. */ package org.apache.reef.tang.examples; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/package-info.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/package-info.java index 48c003e..f695b35 100644 --- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/package-info.java +++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tests for Tang format classes that encode and decode information. */ package org.apache.reef.tang.formats; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/package-info.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/package-info.java index ef641be..92dc469 100644 --- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/package-info.java +++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tests for Tang Avro implementations. */ package org.apache.reef.tang.implementation.avro; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java index 30ca285..e594f92 100644 --- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java +++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java @@ -36,21 +36,21 @@ public class TestConfigurationBuilder { public ExpectedException thrown = ExpectedException.none(); @Test - public void nullStringVaueTest() { + public void nullStringValueTest() { thrown.expect(IllegalStateException.class); thrown.expectMessage("The value null set to the named parameter is illegal: class " + - "org.apache.reef.tang.implementation.java.TestConfigurationBuilder$NamedParamterNoDefault$NamedString"); + "org.apache.reef.tang.implementation.java.TestConfigurationBuilder$NamedParameterNoDefault$NamedString"); Tang.Factory.getTang().newConfigurationBuilder() - .bindNamedParameter(NamedParamterNoDefault.NamedString.class, (String) null) + .bindNamedParameter(NamedParameterNoDefault.NamedString.class, (String) null) .build(); } - static class NamedParamterNoDefault { + static class NamedParameterNoDefault { private final String str; @Inject - NamedParamterNoDefault(@Parameter(NamedString.class) final String str) { + NamedParameterNoDefault(@Parameter(NamedString.class) final String str) { this.str = str; } http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/package-info.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/package-info.java index 669dd6d..4ddf596 100644 --- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/package-info.java +++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tests for Tang Java implementations. */ package org.apache.reef.tang.implementation.java; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/package-info.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/package-info.java index be446fd..3dbbe21 100644 --- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/package-info.java +++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tests for Tang implementations. */ package org.apache.reef.tang.implementation; http://git-wip-us.apache.org/repos/asf/reef/blob/db353052/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/package-info.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/package-info.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/package-info.java index 626ed1e..82d0412 100644 --- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/package-info.java +++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/package-info.java @@ -17,6 +17,6 @@ * under the License. */ /** - * TODO: Document. + * Tests for Tang. */ package org.apache.reef.tang;
