Repository: reef Updated Branches: refs/heads/master db3530528 -> 381553643
[REEF-1042] JobSubmissionDirectoryPrefixParameter bind at C# is not used at Java client This PR expose jobSubmissionDirectoryPrefix from YarnClusterSubmissionFromCS Set the value get from C# to the named parameter JobSubmissionDirectoryPrefix before injecting YarnJobSubmissionClient so that it will be used in JobSubmissionDirectoryProviderImpl instead of default JIRA: [REEF-1042](https://issues.apache.org/jira/browse/REEF-1042) Pull Request: Closes #706 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/38155364 Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/38155364 Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/38155364 Branch: refs/heads/master Commit: 3815536434f846f395a1e98f2bd77d62ef41fd2d Parents: db35305 Author: Julia Wang <[email protected]> Authored: Fri Dec 4 17:14:13 2015 -0800 Committer: Andrew Chung <[email protected]> Committed: Mon Dec 7 11:49:44 2015 -0800 ---------------------------------------------------------------------- .../reef/bridge/client/YarnClusterSubmissionFromCS.java | 7 +++++++ .../apache/reef/bridge/client/YarnJobSubmissionClient.java | 2 ++ 2 files changed, 9 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/38155364/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java index f0b5e6c..6783aa8 100644 --- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java +++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java @@ -180,6 +180,13 @@ final class YarnClusterSubmissionFromCS { } /** + * @return job Submission Directory Prefix which is serialized from C# + */ + String getJobSubmissionDirectoryPrefix() { + return jobSubmissionDirectoryPrefix; + } + + /** * Takes the YARN cluster job submission configuration file, deserializes it, and creates submission object. */ static YarnClusterSubmissionFromCS fromJobSubmissionParametersFile(final File yarnClusterJobSubmissionParametersFile) http://git-wip-us.apache.org/repos/asf/reef/blob/38155364/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java index 93e3e92..daa1396 100644 --- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java +++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java @@ -37,6 +37,7 @@ import org.apache.reef.runtime.yarn.client.SecurityTokenProvider; import org.apache.reef.runtime.yarn.client.YarnSubmissionHelper; import org.apache.reef.runtime.yarn.client.uploader.JobFolder; import org.apache.reef.runtime.yarn.client.uploader.JobUploader; +import org.apache.reef.runtime.yarn.driver.parameters.JobSubmissionDirectoryPrefix; import org.apache.reef.runtime.yarn.util.YarnConfigurationConstructor; import org.apache.reef.tang.Configuration; import org.apache.reef.tang.Tang; @@ -246,6 +247,7 @@ public final class YarnJobSubmissionClient { final Configuration yarnJobSubmissionClientConfig = Tang.Factory.getTang().newConfigurationBuilder() .bindImplementation(RuntimeClasspathProvider.class, YarnClasspathProvider.class) .bindConstructor(org.apache.hadoop.yarn.conf.YarnConfiguration.class, YarnConfigurationConstructor.class) + .bindNamedParameter(JobSubmissionDirectoryPrefix.class, yarnSubmission.getJobSubmissionDirectoryPrefix()) .bindList(DriverLaunchCommandPrefix.class, launchCommandPrefix) .build(); final YarnJobSubmissionClient client = Tang.Factory.getTang().newInjector(yarnJobSubmissionClientConfig)
