ShadowySpirits commented on code in PR #5834:
URL: https://github.com/apache/rocketmq/pull/5834#discussion_r1063068907
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -849,7 +849,11 @@ public GetMessageResult getMessage(final String group,
final String topic, final
continue;
}
-
this.storeStatsService.getGetMessageTransferredMsgCount().add(cqUnit.getBatchNum());
+ if (topicConfig.isPresent()) {
+ if
(!topicConfig.get().getTopicName().contains(TopicValidator.RMQ_SYS_REVIVE_LOG))
{
Review Comment:
Store metrics should not exclude specified topics. It's better to add a new
counter in BrokerStatsManager to calculate the message transfer count excluding
all system topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
