ShadowySpirits commented on code in PR #5834:
URL: https://github.com/apache/rocketmq/pull/5834#discussion_r1063998639
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -848,8 +848,8 @@ public GetMessageResult getMessage(final String group,
final String topic, final
selectResult.release();
continue;
}
-
this.storeStatsService.getGetMessageTransferredMsgCount().add(cqUnit.getBatchNum());
+
this.brokerStatsManager.incBrokerGetNumsWithoutSystemTopic(topic,
cqUnit.getBatchNum());
Review Comment:
Using brokerStatsManager in the store module looks weird... It's better to
add this counter in BrokerStatsManager#incBrokerGetNums.
##########
store/src/main/java/org/apache/rocketmq/store/stats/BrokerStats.java:
##########
@@ -88,6 +88,6 @@ public long getMsgPutTotalTodayNow() {
}
public long getMsgGetTotalTodayNow() {
Review Comment:
How about dealing with getMsgGetTotalYesterdayMorning in the same way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
