mxsm commented on PR #5957: URL: https://github.com/apache/rocketmq/pull/5957#issuecomment-1409657484
> This optimization does not make much sense. In the same constructor, some use `addSystemTopic` and some don't call it, which leads to troublesome understanding instead. Hi @echooymxq IMO,It's not that it's not added to the collection, it's already added. You don't have to repeat the work just to reinforce understanding. Understanding the code will reveal that the system topics have already been added to the collection in the static code block of the TopicValidator. I think the code should be kept as simple and concise as possible to minimize repetitive code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
