ShadowySpirits commented on code in PR #5957:
URL: https://github.com/apache/rocketmq/pull/5957#discussion_r1091610035
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -68,7 +68,6 @@ public TopicConfigManager(BrokerController brokerController) {
{
String topic = TopicValidator.RMQ_SYS_SELF_TEST_TOPIC;
TopicConfig topicConfig = new TopicConfig(topic);
- TopicValidator.addSystemTopic(topic);
Review Comment:
Removing this line could lead to misunderstanding. The person who adds the
system topic next time maybe forget to add it to the system topic list in
TopicValidator. I suggest adding a default logic to scan all system topics and
add them to TopicValidator after initiating TopicConfigManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
