lyx2000 commented on code in PR #6522:
URL: https://github.com/apache/rocketmq/pull/6522#discussion_r1159694288
##########
proxy/src/main/java/org/apache/rocketmq/proxy/remoting/activity/ClientManagerActivity.java:
##########
@@ -82,6 +83,7 @@ protected RemotingCommand heartBeat(ChannelHandlerContext
ctx, RemotingCommand r
this.remotingChannelManager.createProducerChannel(ctx.channel(),
data.getGroupName(), clientId),
clientId, request.getLanguage(),
request.getVersion());
+ setClientPropertiesToChannelAttr(clientChannelInfo);
Review Comment:
Well, that's the problem. `ClientChannelInfo` only appears and can be
accessed when client heartbeat. However, when it comes to message actions,
which can not access `ClientChannelInfo`, their ProxyContext's `clientId`,
`language`, and `version` is empty. So in my pr, I put ClientChannelInfo to
channel attr, in order that message actions' ProxyContext also have those
client properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
