GenerousMan opened a new pull request, #6568:
URL: https://github.com/apache/rocketmq/pull/6568

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   [RIP-63] Issue #6567 .
   Optimize the proxy's and client's selection strategy for brokers when 
sending messages, and use multiple selection strategies as a pipeline to filter 
suitable queues.
   
   ## Brief changelog
   
   ### Client:
   - Modified the files in org.apache.rocketmq.client.latency, such as 
`MQFaultStrategy` and `LatencyFaultTolerance`. These changes implemented 
queues's filters, which will provide more flexible selecting strategies.
   - Added some switches and configs in ClientConfig, to control this strategy.
   - Modified the updateFaultItem() method in the sending process. This method 
is designed to help record the brokers' available status. Now it will also 
record whether brokers are reachable or not.
   
   ### Proxy:
   - Added the MQFaultStrategy in the topicRouteService. It will provide a 
similar queue selection mechanism in the client.
   - Added some switches and configs in ProxyConfig, to control this strategy.
   - Implemented the `selectOneByPipeline()` in `MessageQueueSelector`. It will 
call the filters in mqFaultStrategy to select suitable queue while sending 
messages.
   - Modified the implement of `select()` in SendMessageQueueSelector, now it 
will call the `selectOneByPipeline()`, but not the `selectOne()` before.(PS: If 
the switch is not opened, it will also run as `selectOne()`).
   - Added updateFaultItem() in the ProducerProcessor's sendMessage to record 
brokers' status, according to sending results.
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to