fuyou001 commented on code in PR #6568:
URL: https://github.com/apache/rocketmq/pull/6568#discussion_r1162625334
##########
client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java:
##########
@@ -33,6 +33,13 @@ public int incrementAndGet() {
return Math.abs(index & POSITIVE_MASK);
}
+ public void reset() {
+ int index = Math.abs(random.nextInt());
+ if (index < 0)
+ index = 0;
Review Comment:
the code redundant
##########
client/src/main/java/org/apache/rocketmq/client/ClientConfig.java:
##########
@@ -79,6 +89,10 @@ public class ClientConfig {
*/
protected boolean enableStreamRequestType = false;
+ private boolean sendLatencyEnable =
Boolean.parseBoolean(System.getProperty(SEND_LATENCY_ENABLE, "false"));
Review Comment:
Would it be prudent to incorporate a warning concerning order messaging
within the document
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -2846,6 +2849,37 @@ public void setMessageRequestMode(final String
brokerAddr, final String topic, f
throw new MQClientException(response.getCode(),
response.getRemark());
}
}
+ public Properties queryRemoteClientConfig(long timeoutMillis)
Review Comment:
may be increased namesrv server load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
