sunxiaojian commented on code in PR #81: URL: https://github.com/apache/rocketmq-schema-registry/pull/81#discussion_r1176115248
########## storage-jdbc/src/main/java/org/apache/rocketmq/schema/registry/storage/jdbc/JdbcStoragePlugin.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.rocketmq.schema.registry.storage.jdbc; + +import org.apache.rocketmq.schema.registry.common.context.StoragePluginContext; +import org.apache.rocketmq.schema.registry.common.model.StorageType; +import org.apache.rocketmq.schema.registry.common.storage.StorageFactory; +import org.apache.rocketmq.schema.registry.common.storage.StoragePlugin; + +/** + * Mysql storage plugin + */ +public class JdbcStoragePlugin + implements StoragePlugin { + @Override + public StorageType getType() { + return StorageType.JDBC; + } + + @Override + public StorageFactory load(StoragePluginContext context) { + return new JdbcStorageFactory(context); + } Review Comment: > 能帮忙改下这里的插件实现吗？现在的插件实现中，先是用spi机制加载出plugin，然后由plugin load出StorageFactory，最后由StorageFactory的spring context中找到StorageService，为什么不能直接spi或者spring相关的到StorageService呢？需要绕这么大个弯 @ni-ze 这个是框架初始定义（plugin->factory->service），另提PR优化吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
