mxsm commented on code in PR #6680:
URL: https://github.com/apache/rocketmq/pull/6680#discussion_r1185168051
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java:
##########
@@ -57,7 +57,8 @@ public void messageQueueChanged(String topic,
Set<MessageQueue> mqAll, Set<Messa
* Fix: inconsistency subscription may lead to consumer miss messages.
*/
SubscriptionData subscriptionData = this.subscriptionInner.get(topic);
- long newVersion = System.currentTimeMillis();
Review Comment:
This is also a good way, but I think using the increment method is simpler.
Both have their own advantages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]