lizhanhui commented on code in PR #7065:
URL: https://github.com/apache/rocketmq/pull/7065#discussion_r1277118325
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -746,7 +760,12 @@ public boolean initializeMetadata() {
public boolean initializeMessageStore() {
boolean result = true;
try {
- DefaultMessageStore defaultMessageStore = new
DefaultMessageStore(this.messageStoreConfig, this.brokerStatsManager,
this.messageArrivingListener, this.brokerConfig,
topicConfigManager.getTopicConfigTable());
+ DefaultMessageStore defaultMessageStore;
+ if (isEnableRocksDBStore()) {
Review Comment:
Will SPI be a better choice than `if...else`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
