lizhanhui commented on code in PR #7065:
URL: https://github.com/apache/rocketmq/pull/7065#discussion_r1277150541
##########
common/pom.xml:
##########
@@ -104,5 +104,10 @@
<groupId>io.github.aliyunmq</groupId>
<artifactId>rocketmq-logback-classic</artifactId>
</dependency>
+ <!-- rocksdb -->
+ <dependency>
+ <groupId>io.github.aliyunmq</groupId>
Review Comment:
@fujian-zfj Your purpose of building custom rocksdb is to define a
compaction filter. What a custom compaction filter expects is native function.
Will this way be better alternative:
1. Use official rocksdb-java jar;
2. Build a shared library(dynamically linked with rocksdb shared library)
for expected custom compaction filters;
3. When configuring RocksDB, pass the native function to it, because it does
not matter which shared library the compaction filter stays in;
As a matter of fact, this is how the native programming languages use
rocksdb in case of dynamic link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
