weihubeats commented on code in PR #7238:
URL: https://github.com/apache/rocketmq/pull/7238#discussion_r1305544339
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/channel/GrpcClientChannel.java:
##########
@@ -210,7 +211,7 @@ protected CompletableFuture<Void>
processCheckTransaction(CheckTransactionStateR
protected CompletableFuture<Void>
processGetConsumerRunningInfo(RemotingCommand command,
GetConsumerRunningInfoRequestHeader header,
CompletableFuture<ProxyRelayResult<ConsumerRunningInfo>>
responseFuture) {
- if (!header.isJstackEnable()) {
+ if (Objects.isNull(header) || !header.isJstackEnable()) {
Review Comment:
Failure to return will result in a null pointer error causing a large error
log to be printed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
