joeCarf commented on code in PR #7258:
URL: https://github.com/apache/rocketmq/pull/7258#discussion_r1305593441
##########
client/src/main/java/org/apache/rocketmq/client/ClientConfig.java:
##########
@@ -215,7 +215,7 @@ public ClientConfig cloneClientConfig() {
public String getNamesrvAddr() {
Review Comment:
will this be better?
```java
public String getNamesrvAddr() {
String trimmedNamesrvAddr = namesrvAddr.trim();
if (StringUtils.isNotEmpty(namesrvAddr) &&
NameServerAddressUtils.NAMESRV_ENDPOINT_PATTERN.matcher(trimmedNamesrvAddr).matches())
{
return
NameServerAddressUtils.getNameSrvAddrFromNamesrvEndpoint(trimmedNamesrvAddr);
}
return namesrvAddr;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
