redlsz commented on code in PR #7359:
URL: https://github.com/apache/rocketmq/pull/7359#discussion_r1326876811
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java:
##########
@@ -54,6 +56,11 @@ public void suspendPullRequest(final String topic, final int
queueId, final Pull
pullRequest.getRequestCommand().setSuspended(true);
mpr.addPullRequest(pullRequest);
+ // check the last notify maxOffset
Review Comment:
Won't. The implementation of notifyMessageArriving guarantees that each
request will only be processed once even in concurrent scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
