redlsz commented on code in PR #7359:
URL: https://github.com/apache/rocketmq/pull/7359#discussion_r1327266061
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java:
##########
@@ -36,6 +36,8 @@ public class PullRequestHoldService extends ServiceThread {
private final SystemClock systemClock = new SystemClock();
protected ConcurrentMap<String/* topic@queueId */, ManyPullRequest>
pullRequestTable =
new ConcurrentHashMap<>(1024);
+ protected ConcurrentMap<String/* topic@queueId */, Long/* offset */>
lastNotifyMaxOffset =
Review Comment:
> When deleting a topic or reducing the number of queues, the memory of
lastNotifyMaxOffset may be leaked.
Indeed. But the leak is very slight? The pullRequestTable has the same
issue. Of course, I can append a fix commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
