lizhanhui commented on code in PR #8600:
URL: https://github.com/apache/rocketmq/pull/8600#discussion_r1737993975
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -637,6 +637,26 @@ public String encode() {
return encode(false);
}
+ public boolean loadDataVersion() {
+ String fileName = null;
+ try {
+ fileName = this.configFilePath();
+ String jsonString = MixAll.file2String(fileName);
+ if (jsonString != null) {
+ TopicConfigSerializeWrapper topicConfigSerializeWrapper =
+ TopicConfigSerializeWrapper.fromJson(jsonString,
TopicConfigSerializeWrapper.class);
+ if (topicConfigSerializeWrapper != null) {
+
this.dataVersion.assignNewOne(topicConfigSerializeWrapper.getDataVersion());
+ }
+ log.info("load topic metadata dataVersion success" + fileName
+ " " + topicConfigSerializeWrapper.getDataVersion());
Review Comment:
log should use template interpolation. aka, log.info("bla...{}", value);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
