fuyou001 commented on code in PR #8600:
URL: https://github.com/apache/rocketmq/pull/8600#discussion_r1740778775
##########
broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOffsetManager.java:
##########
@@ -373,6 +374,25 @@ public void setDataVersion(DataVersion dataVersion) {
this.dataVersion = dataVersion;
}
+ public boolean loadDataVersion() {
+ String fileName = null;
+ try {
+ fileName = this.configFilePath();
+ String jsonString = MixAll.file2String(fileName);
+ if (jsonString != null) {
+ ConsumerOffsetManager obj =
RemotingSerializable.fromJson(jsonString, ConsumerOffsetManager.class);
+ if (obj != null) {
+ this.dataVersion = obj.dataVersion;
Review Comment:
when dataVersion update? the dataVersion only changes during the HA switch
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -789,6 +788,9 @@ public boolean initializeMessageStore() {
defaultMessageStore = new
RocksDBMessageStore(this.messageStoreConfig, this.brokerStatsManager,
this.messageArrivingListener, this.brokerConfig,
topicConfigManager.getTopicConfigTable());
} else {
defaultMessageStore = new
DefaultMessageStore(this.messageStoreConfig, this.brokerStatsManager,
this.messageArrivingListener, this.brokerConfig,
topicConfigManager.getTopicConfigTable());
+ if (messageStoreConfig.isRocksdbCQWriteEnable()) {
Review Comment:
must be isEnableRocksDBStore is true ,This feature can only be enabled when
isEnableRocksDBStore is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
