RongtongJin opened a new pull request, #8939: URL: https://github.com/apache/rocketmq/pull/8939
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. --> ### Which Issue(s) This PR Fixes <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. --> Fixes #8829 In the current v1 version, lmq consumer offsets are only stored in memory, which means they will be lost if the broker restarts or crashes. To address this, #8856 @Lizhanhui developed v2 to enable storing lmq consumer offsets in RocksDB. However, upgrading from v1 to v2 with backward compatibility is not feasible. Therefore, it's crucial to introduce support for persisting lmq consumer offsets in v1. ### Brief Description <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. --> To streamline the implementation, we will not use a separate class for lmq consumer offset storage. Instead, we will leverage the existing RocksDBConsumerOffsetManager. Under the v1 metadata configuration, this manager will handle both lmq and non-lmq consumer offsets collectively. ### How Did You Test This Change? <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
