DongyuanPan commented on code in PR #8939:
URL: https://github.com/apache/rocketmq/pull/8939#discussion_r1845746471
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -352,7 +351,7 @@ public BrokerController(
} else if (this.messageStoreConfig.isEnableRocksDBStore()) {
this.topicConfigManager = messageStoreConfig.isEnableLmq() ? new
RocksDBLmqTopicConfigManager(this) : new RocksDBTopicConfigManager(this);
this.subscriptionGroupManager = messageStoreConfig.isEnableLmq() ?
new RocksDBLmqSubscriptionGroupManager(this) : new
RocksDBSubscriptionGroupManager(this);
- this.consumerOffsetManager = messageStoreConfig.isEnableLmq() ?
new RocksDBLmqConsumerOffsetManager(this) : new
RocksDBConsumerOffsetManager(this);
+ this.consumerOffsetManager = new
RocksDBConsumerOffsetManager(this);
Review Comment:
Maybe it's better to make a feature switch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
