RongtongJin commented on code in PR #9996:
URL: https://github.com/apache/rocketmq/pull/9996#discussion_r2671013683
##########
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java:
##########
@@ -95,7 +95,6 @@ private void syncTopicConfig() {
if (!newTopicConfigTable.containsKey(entry.getKey())) {
iterator.remove();
}
- topicConfigManager.deleteTopicConfig(entry.getKey());
Review Comment:
Putting deleteTopicConfig outside the if does indeed reduce efficiency
because it clears all data before re-adding it (especially when there’s a large
amount of metadata). However, removing it directly would prevent topicConfig
entries of the RocksDB type from being deleted during synchronization. We may
need to come up with a better approach to address this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
