RongtongJin commented on code in PR #9996:
URL: https://github.com/apache/rocketmq/pull/9996#discussion_r2671196587
##########
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java:
##########
@@ -95,7 +95,6 @@ private void syncTopicConfig() {
if (!newTopicConfigTable.containsKey(entry.getKey())) {
iterator.remove();
}
- topicConfigManager.deleteTopicConfig(entry.getKey());
Review Comment:
> I got that. I've revised it again. This implementation should be able to
delete the deleted topics' topicConfig instances in RocksDB. Please help to
review it again.
Not sure whether deleting while iterating could cause any conflicts. Would
it be better to first collect the items to be deleted into a list and then
remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
